On 05/28/2017 04:18 AM, Niels de Vos wrote:
On Fri, May 26, 2017 at 12:25:42PM -0400, Shyam wrote:
Or this one: https://review.gluster.org/15036
This is backported to 3.8/10 and 3.11 and considering the size and impact of
the change, I wanted to be sure that we are going to accept this across all
3 releases?
@Du, would like your thoughts on this.
@niels, @kaushal, @talur, as release owners, could you weigh in as well
please.
I am thinking that we get this into 3.11.1 if there is agreement, and not in
3.11.0 as we are finalizing the release in 3 days, and this change looks
big, to get in at this time.
Further the change is actually an enhancement, and provides performance
benefits, so it is valid as a change itself, but I feel it is too late to
add to the current 3.11 release.
Indeed, and mostly we do not merge enhancements that are non-trivial to
stable branches. Each change that we backport introduces the chance on
regressions for users with their unknown (and possibly awkward)
workloads.
The patch itself looks ok, but it is difficult to predict how the change
affects current deployments. I prefer to be conservative and not have
this merged in 3.8, at least for now. Are there any statistics in how
performance is affected with this change? Having features like this only
in newer versions might also convince users to upgrade sooner, 3.8 will
only be supported until 3.12 (or 4.0) gets released, which is approx. 3
months from now according to our schedule.
I agree, considering where we are at w.r.t 3.8 and the nature of this
change, I think we should release this along with 3.12, and not backport
the change.
I am anyway taking the decision of not adding this to 3.11.0 at the
moment, considering the change is submitted very late, and I do not want
to risk any destabilization of the build at the moment.
Niels
_______________________________________________
Gluster-devel mailing list
Gluster-devel@xxxxxxxxxxx
http://lists.gluster.org/mailman/listinfo/gluster-devel
