Sure, will setup it from next week onward.-RajeshOn Mon, Jan 2, 2017 at 4:38 PM, <sriram@xxxxxxxxxxxxx> wrote:Hi Rajesh,Right now bi-weekly should be ok, with progress we could decide. I'll continue to rework the initial patch set and post it for review. We'll take it from there, is that ok with you?SriramOn Mon, Jan 2, 2017, at 03:32 PM, Rajesh Joseph wrote:On Mon, Jan 2, 2017 at 3:19 PM, <sriram@xxxxxxxxxxxxx> wrote:Hi Avra,Is the below request ok with you?SriramOn Wed, Dec 21, 2016, at 10:00 AM, sriram@xxxxxxxxxxxxx wrote:Hi Avra/Rajesh,In continuation to the discussion we'd yesterday, I'd be working on the change we'd initiated sometime back for pluggable FS specific snapshot implementation. We'd be moving our gluster deployements to "master" (stable) once this feature goes in. Since, glusterd2.0 release is scheduled release next year, I'd be happy if some of the work done here is re-usable to glusterd2.0 as well.Let me know, if this is ok. Like Rajesh mentioned in the call, could we've a weekly meeting for the same feature?Hi Sriram,I was on vacation so could not reply to your mail.I am OK with having a regular sync-up on this issue. Let's take this to conclusion.Do we need a weekly meeting or bi-weekly meeting is fine?Best Regards,RajeshSriramOn Mon, Dec 19, 2016, at 03:55 PM, asengupt@xxxxxxxxxx wrote:
Re: Question on merging zfs snapshot support into the mainline glusterfs
Hi Sriram,Could you please join the hangout, so that we can discuss snapshot plugabbility. Thanks
Meeting Link: https://bluejeans.com/u/asengu
pt/ Regards,
AvraOn 12/19/2016 01:38 PM, sriram@xxxxxxxxxxxxx wrote:
> Hi Avra,
>
> Could you help on the below request? May I abandon the previous submitted patches, and could we consider the latest one?
>
> Sriram
>
>
> On Thu, Dec 15, 2016, at 12:57 PM, sriram@xxxxxxxxxxxxx wrote:
>> Hi Avra,
>>
>> Thanks for the reply,
>>
>> But the problem I see here is the previous patch set sent would'nt compile individually. So, I merged the changes into a single patch , which i'd posted today. Is it ok to drop all the previous posted patches and consider from the new one? Please suggest.
>>
>> Sriram
>>
>>
>> On Thu, Dec 15, 2016, at 12:45 PM, Avra Sengupta wrote:
>>> Hi Sriram,
>>>
>>> I have already provided comments on the new patch. It seems this new patch while addressing merge cloflicts, has undone some previous patches. I suggest you send this patch on top of the previous patchset(http://review.gluster.org/#/c/15554/1 ) instead of creating a new one. This will allow you to view the diff between the new version and the previous version, and will give u an idea if the diff is something that you added in the patch or got added as part of merge conflict.
>>>
>>> Regards,
>>> Avra
>>>
>>> On 12/15/2016 12:09 PM, sriram@xxxxxxxxxxxxx wrote:
>>>> Hi Avra,
>>>>
>>>> I've update the patch according to the comments below. And created a single patch which does the initial modularization. Fixed the tab->space issue as well. I've raised a new review request for the same bug ID here:
>>>> http://review.gluster.org/#/c/16138/
>>>>
>>>> Added, Rajesh and You as the reviewers, let me know if I need to do anything else.
>>>>
>>>> Could you have a look and let me know?
>>>>
>>>> (Sorry for the delay in creating this)
>>>>
>>>> Sriram
>>>>
>>>> On Thu, Oct 13, 2016, at 12:15 PM, Avra Sengupta wrote:
>>>>> Hi Sriram,
>>>>>
>>>>> The point I was trying to make is, that we want that each patch should compile by itself, and pass regression. So for that to happen, we need to consolidate these patches(the first three) into one patch, and have the necessary make file changes into that patch too.
>>>>>
>>>>> http://review.gluster.org/#/c/15554/
>>>>> http://review.gluster.org/#/c/15555/
>>>>> http://review.gluster.org/#/c/15556/
>>>>>
>>>>> That will give us one single patch, that contains the changes of having the current code moved into separate files, and it should get compiled on it's own, and should pass regression. Also, we use spaces, and not tabs in the code. So we will need to get those changed too. Thanks.
>>>>>
>>>>> Regards,
>>>>> Avra
>>>>>
>>>>> On 10/12/2016 10:46 PM, sriram@xxxxxxxxxxxxx wrote:
>>>>>> Hi Avra,
>>>>>>
>>>>>> Could you let me know on the below request?
>>>>>>
>>>>>> Sriram
>>>>>>
>>>>>>
>>>>>> On Tue, Oct 4, 2016, at 11:16 AM, sriram@xxxxxxxxxxxxx wrote:
>>>>>>> Hi Avra,
>>>>>>>
>>>>>>> I checked the comment, the series of patches, (There are nine patches) for which I've posted for a review below. They've all the necessary makefiles to compile.
>>>>>>>
>>>>>>> Would you want me to consolidate all'em and post them as a single patch? (I thought that would be a little confusing, since it'd changes with different intentions).
>>>>>>>
>>>>>>> Sriram
>>>>>>>
>>>>>>>
>>>>>>> On Mon, Oct 3, 2016, at 03:54 PM, Avra Sengupta wrote:
>>>>>>>> Hi Sriram,
>>>>>>>>
>>>>>>>> I posted a comment into the first patch. It doesn't compile by itself. We need to update the respective makefiles to be able to compile it. Then we can introduce the tabular structure in the same patch to have the framework set for the zfs snapshots. Thanks.
>>>>>>>>
>>>>>>>> Regards,
>>>>>>>> Avra
>>>>>>>>
>>>>>>>> On 09/30/2016 10:24 AM, sriram@xxxxxxxxxxxxx wrote:
>>>>>>>>> Hi Avra,
>>>>>>>>>
>>>>>>>>> Could you have a look into the below request?
>>>>>>>>>
>>>>>>>>> Sriram
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> On Fri, Sep 23, 2016, at 04:10 PM, sriram@xxxxxxxxxxxxx wrote:
>>>>>>>>>> Hi Avra,
>>>>>>>>>>
>>>>>>>>>> Have submitted the patches for Modularizing snapshot,
>>>>>>>>>>
>>>>>>>>>> https://bugzilla.redhat.com/show_bug.cgi?id=1377437
>>>>>>>>>>
>>>>>>>>>> This is the patch set:
>>>>>>>>>>
>>>>>>>>>> http://review.gluster.org/15554 This patch follows the discussion from the gluster-devel mail chain of, ...
>>>>>>>>>> http://review.gluster.org/15555 Referring to bugID:1377437, Modularizing snapshot for plugin based modules.
>>>>>>>>>> http://review.gluster.org/15556 - This is third patch in the series for the bug=1377437
>>>>>>>>>> http://review.gluster.org/15557 [BugId:1377437][Patch4]: Refering to the bug ID,
>>>>>>>>>> http://review.gluster.org/15558 [BugId:1377437][Patch5]: Refering to the bug ID,
>>>>>>>>>> http://review.gluster.org/15559 [BugId:1377437][Patch6]: Refering to the bug ID,
>>>>>>>>>> http://review.gluster.org/15560 [BugId:1377437][Patch7]: Refering to the bug ID. * This patch has some minor ...
>>>>>>>>>> http://review.gluster.org/15561 [BugId:1377437][Patch8]: Refering to the bug ID, this commit has minor fixes ...
>>>>>>>>>> http://review.gluster.org/15562 [BugId:1377437][Patch9]: Refering to the bug ID, - Minor header file ...
>>>>>>>>>>
>>>>>>>>>> Primarily, focused on moving lvm based implementation into plugins. Have spread the commits across nine patches, some of them are minors, except a couple of ones which does the real work. Others are minors. Followed this method since, it would be easy for a review (accept/reject). Let me know if there is something off the methods followed with gluster devel. Thanks
>>>>>>>>>>
>>>>>>>>>> Sriram
>>>>>>>>>>
>>>>>>>>>> On Mon, Sep 19, 2016, at 10:58 PM, Avra Sengupta wrote:
>>>>>>>>>>> Hi Sriram,
>>>>>>>>>>>
>>>>>>>>>>> I have created a bug for this (https://bugzilla.redhat.com/show_bug.cgi?id=1377437 ). The plan is that for the first patch as mentioned below, let's not meddle with the zfs code at all. What we are looking at is segregating the lvm based code as is today, from the management infrastructure (which is addressed in your patch), and creating a table based pluggable infra(refer to gd_svc_cli_actors[] in xlators/mgmt/glusterd/src/glusterd-handler.c and other similar tables in gluster code base to get a understanding of what I am conveying), which can be used to call this code and still achieve the same results as we do today.
>>>>>>>>>>>
>>>>>>>>>>> Once this code is merged, we can use the same infra to start pushing in the zfs code (rest of your current patch). Please let me know if you have further queries regarding this. Thanks.
>>>>>>>>>>>
>>>>>>>>>>> Regards,
>>>>>>>>>>> Avra
>>>>>>>>>>>
>>>>>>>>>>> On 09/19/2016 07:52 PM, sriram@xxxxxxxxxxxxx wrote:
>>>>>>>>>>>> Hi Avra,
>>>>>>>>>>>>
>>>>>>>>>>>> Do you have a bug id for this changes? Or may I raise a new one?
>>>>>>>>>>>>
>>>>>>>>>>>> Sriram
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> On Fri, Sep 16, 2016, at 11:37 AM, sriram@xxxxxxxxxxxxx wrote:
>>>>>>>>>>>>> Thanks Avra,
>>>>>>>>>>>>>
>>>>>>>>>>>>> I'll send this patch to gluster master in a while.
>>>>>>>>>>>>>
>>>>>>>>>>>>> Sriram
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> On Wed, Sep 14, 2016, at 03:08 PM, Avra Sengupta wrote:
>>>>>>>>>>>>>> Hi Sriram,
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Sorry for the delay in response. I started going through the commits in the github repo. I finished going through the first commit, where you create a plugin structure and move code. Following is the commit link:
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> https://github.com/sriramster/glusterfs/commit/7bf1575255395 41ebf0aa36a380bbedb2cae5440
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> FIrst of all, the overall approach of using plugins, and maintaining plugins that is used in the patch is in sync with what we had discussed. There are some gaps though, like in the zfs functions the snap brick is mounted without updating labels, and in restore you perform a zfs rollback, which significantly changes the behavior between how a lvm based snapshot and a zfs based snapshot.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> But before we get into these details, I would request you to kindly send this particular patch to the g
Tue Dec 20, 2016 2:30pm – 3:30pm India Standard Time sriram@xxxxxxxxxxxxx
• • • • • Going? Yes - Maybe - No more options »
Invitation from Google Calendar
You are receiving this courtesy email at the account sriram@xxxxxxxxxxxxx because you are an attendee of this event.
To stop receiving future updates for this event, decline this event. Alternatively you can sign up for a Google account at https://www.google.com/calenda
r/ and control your notification settings for your entire calendar.Forwarding this invitation could allow any recipient to modify your RSVP response. Learn More.
Email had 2 attachments:
Attachment1.310k (text/calendar)invite.ics14k (application/ics)_______________________________________________ Gluster-devel mailing list
_______________________________________________ Gluster-devel mailing list Gluster-devel@xxxxxxxxxxx http://www.gluster.org/mailman/listinfo/gluster-devel
