BEGIN:VCALENDAR PRODID:-//Google Inc//Google Calendar 70.9054//EN VERSION:2.0 CALSCALE:GREGORIAN METHOD:REQUEST BEGIN:VEVENT DTSTART:20161220T090000Z DTEND:20161220T100000Z DTSTAMP:20161219T102548Z ORGANIZER;CN=asengupt@xxxxxxxxxx:mailto:asengupt@xxxxxxxxxx UID:abh2kp4p3sq2482m4coieimc6o@xxxxxxxxxx ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP= TRUE;CN=rjoseph@xxxxxxxxxx;X-NUM-GUESTS=0:mailto:rjoseph@xxxxxxxxxx ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP= TRUE;CN=ram@xxxxxxxxxxxxx;X-NUM-GUESTS=0:mailto:ram@xxxxxxxxxxxxx ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP= TRUE;CN=gluster-devel@xxxxxxxxxxx;X-NUM-GUESTS=0:mailto:gluster-devel@glust er.org ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=ACCEPTED;RSVP=TRUE ;CN=asengupt@xxxxxxxxxx;X-NUM-GUESTS=0:mailto:asengupt@xxxxxxxxxx ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP= TRUE;CN=sriram@xxxxxxxxxxxxx;X-NUM-GUESTS=0:mailto:sriram@xxxxxxxxxxxxx CREATED:20161219T102548Z DESCRIPTION:Hi Sriram\,\n\nCould you please join the hangout\, so that we c an discuss snapshot plugabbility. Thanks\n\nMeeting Link: https://bluejeans .com/u/asengupt/\n\nRegards\,\nAvra\n\nOn 12/19/2016 01:38 PM\, sriram@mari rs.net.in wrote:\n> Hi Avra\,\n>\n> Could you help on the below request? M ay I abandon the previous submitted patches\, and could we consider the lat est one?\n>\n> Sriram\n>\n>\n> On Thu\, Dec 15\, 2016\, at 12:57 PM\, srira m@xxxxxxxxxxxxx wrote:\n>> Hi Avra\,\n>>\n>> Thanks for the reply\,\n>>\n>> But the problem I see here is the previous patch set sent would'nt compile individually. So\, I merged the changes into a single patch \, which i'd p osted today. Is it ok to drop all the previous posted patches and consider from the new one? Please suggest.\n>>\n>> Sriram\n>>\n>>\n>> On Thu\, Dec 1 5\, 2016\, at 12:45 PM\, Avra Sengupta wrote:\n>>> Hi Sriram\,\n>>>\n>>> I have already provided comments on the new patch. It seems this new patch wh ile addressing merge cloflicts\, has undone some previous patches. I sugges t you send this patch on top of the previous patchset(http://review.gluster .org/#/c/15554/1) instead of creating a new one. This will allow you to vie w the diff between the new version and the previous version\, and will give u an idea if the diff is something that you added in the patch or got adde d as part of merge conflict.\n>>>\n>>> Regards\,\n>>> Avra\n>>>\n>>> On 12/ 15/2016 12:09 PM\, sriram@xxxxxxxxxxxxx wrote:\n>>>> Hi Avra\,\n>>>>\n>>>> I've update the patch according to the comments below. And created a single patch which does the initial modularization. Fixed the tab->space issue as well. I've raised a new review request for the same bug ID here:\n>>>> htt p://review.gluster.org/#/c/16138/\n>>>>\n>>>> Added\, Rajesh and You as the reviewers\, let me know if I need to do anything else.\n>>>>\n>>>> Could y ou have a look and let me know?\n>>>>\n>>>> (Sorry for the delay in creatin g this)\n>>>>\n>>>> Sriram\n>>>>\n>>>> On Thu\, Oct 13\, 2016\, at 12:15 PM \, Avra Sengupta wrote:\n>>>>> Hi Sriram\,\n>>>>>\n>>>>> The point I was tr ying to make is\, that we want that each patch should compile by itself\, a nd pass regression. So for that to happen\, we need to consolidate these pa tches(the first three) into one patch\, and have the necessary make file ch anges into that patch too.\n>>>>>\n>>>>> http://review.gluster.org/#/c/1555 4/\n>>>>> http://review.gluster.org/#/c/15555/\n>>>>> http://review.gluster .org/#/c/15556/\n>>>>>\n>>>>> That will give us one single patch\, that con tains the changes of having the current code moved into separate files\, an d it should get compiled on it's own\, and should pass regression. Also\, w e use spaces\, and not tabs in the code. So we will need to get those chang ed too. Thanks.\n>>>>>\n>>>>> Regards\,\n>>>>> Avra\n>>>>>\n>>>>> On 10/12/ 2016 10:46 PM\, sriram@xxxxxxxxxxxxx wrote:\n>>>>>> Hi Avra\,\n>>>>>>\n>>>> >> Could you let me know on the below request?\n>>>>>>\n>>>>>> Sriram\n>>>> >>\n>>>>>>\n>>>>>> On Tue\, Oct 4\, 2016\, at 11:16 AM\, sriram@xxxxxxxxxx. in wrote:\n>>>>>>> Hi Avra\,\n>>>>>>>\n>>>>>>> I checked the comment\, the series of patches\, (There are nine patches) for which I've posted for a re view below. They've all the necessary makefiles to compile.\n>>>>>>>\n>>>>> >> Would you want me to consolidate all'em and post them as a single patch? (I thought that would be a little confusing\, since it'd changes with diff erent intentions). \n>>>>>>>\n>>>>>>> Sriram\n>>>>>>>\n>>>>>>>\n>>>>>>> On Mon\, Oct 3\, 2016\, at 03:54 PM\, Avra Sengupta wrote:\n>>>>>>>> Hi Sriram \,\n>>>>>>>>\n>>>>>>>> I posted a comment into the first patch. It doesn't compile by itself. We need to update the respective makefiles to be able to compile it. Then we can introduce the tabular structure in the same patch to have the framework set for the zfs snapshots. Thanks.\n>>>>>>>>\n>>>>>>> > Regards\,\n>>>>>>>> Avra\n>>>>>>>>\n>>>>>>>> On 09/30/2016 10:24 AM\, sri ram@xxxxxxxxxxxxx wrote:\n>>>>>>>>> Hi Avra\,\n>>>>>>>>>\n>>>>>>>>> Could y ou have a look into the below request?\n>>>>>>>>>\n>>>>>>>>> Sriram\n>>>>>> >>>\n>>>>>>>>>\n>>>>>>>>> On Fri\, Sep 23\, 2016\, at 04:10 PM\, sriram@mar irs.net.in wrote:\n>>>>>>>>>> Hi Avra\,\n>>>>>>>>>>\n>>>>>>>>>> Have submit ted the patches for Modularizing snapshot\,\n>>>>>>>>>>\n>>>>>>>>>> https:/ /bugzilla.redhat.com/show_bug.cgi?id=1377437\n>>>>>>>>>>\n>>>>>>>>>> This i s the patch set:\n>>>>>>>>>>\n>>>>>>>>>> http://review.gluster.org/15554 T his patch follows the discussion from the gluster-devel mail chain of\, ... \n>>>>>>>>>> http://review.gluster.org/15555 Referring to bugID:1377437\, Modularizing snapshot for plugin based modules.\n>>>>>>>>>> http://review. gluster.org/15556 - This is third patch in the series for the bug=1377437\n >>>>>>>>>> http://review.gluster.org/15557 [BugId:1377437][Patch4]: Referi ng to the bug ID\,\n>>>>>>>>>> http://review.gluster.org/15558 [BugId:1377 437][Patch5]: Refering to the bug ID\,\n>>>>>>>>>> http://review.gluster.o rg/15559 [BugId:1377437][Patch6]: Refering to the bug ID\,\n>>>>>>>>>> htt p://review.gluster.org/15560 [BugId:1377437][Patch7]: Refering to the bug I D. * This patch has some minor ...\n>>>>>>>>>> http://review.gluster.org/1 5561 [BugId:1377437][Patch8]: Refering to the bug ID\, this commit has mino r fixes ...\n>>>>>>>>>> http://review.gluster.org/15562 [BugId:1377437][Pa tch9]: Refering to the bug ID\, - Minor header file ...\n>>>>>>>>>>\n>>>>>> >>>> Primarily\, focused on moving lvm based implementation into plugins. H ave spread the commits across nine patches\, some of them are minors\, exce pt a couple of ones which does the real work. Others are minors. Followed t his method since\, it would be easy for a review (accept/reject). Let me kn ow if there is something off the methods followed with gluster devel. Thank s\n>>>>>>>>>>\n>>>>>>>>>> Sriram\n>>>>>>>>>>\n>>>>>>>>>> On Mon\, Sep 19\, 2016\, at 10:58 PM\, Avra Sengupta wrote:\n>>>>>>>>>>> Hi Sriram\,\n>>>>>>> >>>>\n>>>>>>>>>>> I have created a bug for this (https://bugzilla.redhat.co m/show_bug.cgi?id=1377437). The plan is that for the first patch as mention ed below\, let's not meddle with the zfs code at all. What we are looking a t is segregating the lvm based code as is today\, from the management infra structure (which is addressed in your patch)\, and creating a table based p luggable infra(refer to gd_svc_cli_actors[] in xlators/mgmt/glusterd/src/gl usterd-handler.c and other similar tables in gluster code base to get a und erstanding of what I am conveying)\, which can be used to call this code an d still achieve the same results as we do today.\n>>>>>>>>>>>\n>>>>>>>>>>> Once this code is merged\, we can use the same infra to start pushing in th e zfs code (rest of your current patch). Please let me know if you have fur ther queries regarding this. Thanks.\n>>>>>>>>>>>\n>>>>>>>>>>> Regards\,\n> >>>>>>>>>> Avra\n>>>>>>>>>>>\n>>>>>>>>>>> On 09/19/2016 07:52 PM\, sriram@m arirs.net.in wrote:\n>>>>>>>>>>>> Hi Avra\,\n>>>>>>>>>>>>\n>>>>>>>>>>>> Do you have a bug id for this changes? Or may I raise a new one?\n>>>>>>>>>>>> \n>>>>>>>>>>>> Sriram\n>>>>>>>>>>>>\n>>>>>>>>>>>>\n>>>>>>>>>>>> On Fri\, Se p 16\, 2016\, at 11:37 AM\, sriram@xxxxxxxxxxxxx wrote:\n>>>>>>>>>>>>> Than ks Avra\,\n>>>>>>>>>>>>>\n>>>>>>>>>>>>> I'll send this patch to gluster mas ter in a while.\n>>>>>>>>>>>>>\n>>>>>>>>>>>>> Sriram\n>>>>>>>>>>>>>\n>>>>>> >>>>>>>\n>>>>>>>>>>>>> On Wed\, Sep 14\, 2016\, at 03:08 PM\, Avra Sengupta wrote:\n>>>>>>>>>>>>>> Hi Sriram\,\n>>>>>>>>>>>>>>\n>>>>>>>>>>>>>> Sorry f or the delay in response. I started going through the commits in the github repo. I finished going through the first commit\, where you create a plugi n structure and move code. Following is the commit link:\n>>>>>>>>>>>>>>\n> >>>>>>>>>>>>> https://github.com/sriramster/glusterfs/commit/7bf15752553954 1ebf0aa36a380bbedb2cae5440\n>>>>>>>>>>>>>>\n>>>>>>>>>>>>>> FIrst of all\, t he overall approach of using plugins\, and maintaining plugins that is used in the patch is in sync with what we had discussed. There are some gaps th ough\, like in the zfs functions the snap brick is mounted without updating labels\, and in restore you perform a zfs rollback\, which significantly c hanges the behavior between how a lvm based snapshot and a zfs based snapsh ot.\n>>>>>>>>>>>>>>\n>>>>>>>>>>>>>> But before we get into these details\, I would request you to kindly send this particular patch to the g\nView you r event at https://www.google.com/calendar/event?action=VIEW&eid=YWJoMmtwNH Azc3EyNDgybTRjb2llaW1jNm8gZ2x1c3Rlci1kZXZlbEBnbHVzdGVyLm9yZw&tok=MTkjYXNlbm d1cHRAcmVkaGF0LmNvbTA3NDQwMzMyMjE2N2Q4ZjBiYTMxOTQzYmViNDc4OWQ1NjBjNDhkZDI&c tz=Asia/Calcutta&hl=en. LAST-MODIFIED:20161219T102548Z LOCATION: SEQUENCE:0 STATUS:CONFIRMED SUMMARY:Re: Question on merging zfs snapshot support into t he mainline glusterfs TRANSP:OPAQUE END:VEVENT END:VCALENDAR
Attachment:
invite.ics
Description: application/ics
_______________________________________________ Gluster-devel mailing list Gluster-devel@xxxxxxxxxxx http://www.gluster.org/mailman/listinfo/gluster-devel
