Hi Manikandan, Thanks for the review. Will work on addressing them ASAP. Please feel free to review the remaining files when you find time. ----- Original Message ----- > From: "Manikandan Selvaganesh" <manikandancs333@xxxxxxxxx> > To: "Niels de Vos" <ndevos@xxxxxxxxxx> > Cc: "Hari Gowtham" <hgowtham@xxxxxxxxxx>, "gluster-devel" <gluster-devel@xxxxxxxxxxx>, "Kaushal Madappa" > <kaushal@xxxxxxxxxx> > Sent: Friday, September 16, 2016 1:37:09 PM > Subject: Re: Review request: tier as a service. > > Hi Hari, > > I have done a very initial review for some of the files. I have just > reviewed the code flow without having much idea on the actual > functionality. Please > feel free to address it when you have time(since most of them are coverity, > indentation > and memory issues related). > > I will also review the remaining files when I get time. > > -- > Thanks & Regards, > Manikandan Selvaganesh. > > On Thu, Sep 15, 2016 at 2:22 PM, Niels de Vos <ndevos@xxxxxxxxxx> wrote: > > > On Thu, Sep 15, 2016 at 02:50:09AM -0400, Hari Gowtham wrote: > > > Hi, > > > > > > I would be happy to get reviews for this patch > > > http://review.gluster.org/#/c/13365/ > > > > > > more details can be found here about the changes: > > > https://docs.google.com/document/d/1_iyjiwTLnBJlCiUgjAWnpnPD801h5LN > > xLhHmN7zmk1o/edit?usp=sharing > > > > Please send this as a document for the glusterfs-specs repository (uses > > Gerrit just like the glusterfs sources). See the README.md on > > https://github.com/gluster/glusterfs-specs/blob/master/README.md for > > some more details. > > > > Thanks, > > Niels > > > > _______________________________________________ > > Gluster-devel mailing list > > Gluster-devel@xxxxxxxxxxx > > http://www.gluster.org/mailman/listinfo/gluster-devel > > > -- Regards, Hari. _______________________________________________ Gluster-devel mailing list Gluster-devel@xxxxxxxxxxx http://www.gluster.org/mailman/listinfo/gluster-devel
