On Tue, Aug 23, 2016 at 12:18 PM, Niels de Vos <ndevos@xxxxxxxxxx> wrote: > On Tue, Aug 23, 2016 at 08:16:54PM +0530, Mohammed Rafi K C wrote: >> Hi, >> >> We have pushed a patch for fop serialization on server side [1]. If you >> have some time, please take a look into the patch. You are reviews are >> most welcome :) >> >> >> If I can accommodate all the comments by End of the week, we are >> planning to get this before the coming Friday. > > Without looking into the code yet, I would like to see a different name > for "DFS". It is a function of the Samba protocol, and having a name > like this in the Gluster sources will cause confusion. > > Does this come with a design document in the glusterfs-specs repository? > Features like this can not be accepted without one. If you want this > included in 3.9, it should also get added to > https://www.gluster.org/community/roadmap/3.9/ . It looks a little late > for proposing a new feature, and only have a couple of days to review > the design and a 1500+ patch that does not include any test-cases yet. > If this really is the current state, I suggest to move it to the next > release and use the additional three months (only!) to stabilize it. > +1. We need to have more discussion on this one. Besides a 12 month old email thread, I have not seen more details about this feature. Providing more details on the design, nature of testing done, performance impact if any etc. would be necessary before merging any patchset of this nature. Regards, Vijay _______________________________________________ Gluster-devel mailing list Gluster-devel@xxxxxxxxxxx http://www.gluster.org/mailman/listinfo/gluster-devel
