Oops the authors are not actively contributing to gluster now. Sorry about that. ~Joe ----- Original Message ----- > From: "Joseph Fernandes" <josferna@xxxxxxxxxx> > To: jdarcy@xxxxxxxxxx > Cc: "Gluster Devel" <gluster-devel@xxxxxxxxxxx> > Sent: Monday, February 29, 2016 3:44:57 PM > Subject: Re: Change in glusterfs[master]: tests: fix bug-860663.t > > Hi Jeff, > > I would suggest add the author of this script to the review panel. > > Regards, > Joe > > ----- Original Message ----- > > From: "Jeff Darcy (Code Review)" <review@xxxxxxxxxxxxxxx> > > To: "Joseph Fernandes" <josferna@xxxxxxxxxx> > > Sent: Monday, February 29, 2016 3:42:45 PM > > Subject: Change in glusterfs[master]: tests: fix bug-860663.t > > > > Hello Joseph Fernandes, > > > > I'd like you to do a code review. Please visit > > > > http://review.gluster.org/13544 > > > > to review the following change. > > > > Change subject: tests: fix bug-860663.t > > ...................................................................... > > > > tests: fix bug-860663.t > > > > Three changes: > > > > * Removed the second round of file creation, which wasn't really > > testing anything useful and was causing spurious failures. Under the > > conditions we've set up, the rational expectation would be for the > > file-creation helper program to succeed, but the test expected it to > > fail. > > > > * Removed Yet Another Unnecessary Sleep. > > > > * Reduced the number of files from 10K to 1K. That's more than > > sufficient to test what we're trying to test, and saves significant > > time. > > > > There's still a bit of a mystery about how this test *ever* passed. If > > I want mystery I'll read a detective novel. The more important thing is > > that the line in question was irrelevant to the purpose of the test > > (which had to do with not allowing a fix-layout while bricks were down) > > and was far too heavyweight to be included as a "while we're here might > > as well" kind of addition. > > > > Change-Id: If1c623853745ab42ce7d058d1009bbe1dcc1e985 > > Signed-off-by: Jeff Darcy <jdarcy@xxxxxxxxxx> > > --- > > M tests/bugs/distribute/bug-860663.t > > 1 file changed, 5 insertions(+), 6 deletions(-) > > > > > > git pull ssh://git.gluster.org/glusterfs refs/changes/44/13544/1 > > -- > > To view, visit http://review.gluster.org/13544 > > To unsubscribe, visit http://review.gluster.org/settings > > > > Gerrit-MessageType: newchange > > Gerrit-Change-Id: If1c623853745ab42ce7d058d1009bbe1dcc1e985 > > Gerrit-PatchSet: 1 > > Gerrit-Project: glusterfs > > Gerrit-Branch: master > > Gerrit-Owner: Jeff Darcy <jdarcy@xxxxxxxxxx> > > Gerrit-Reviewer: Joseph Fernandes <josferna@xxxxxxxxxx> > > Gerrit-Reviewer: N Balachandran <nbalacha@xxxxxxxxxx> > > > _______________________________________________ > Gluster-devel mailing list > Gluster-devel@xxxxxxxxxxx > http://www.gluster.org/mailman/listinfo/gluster-devel > _______________________________________________ Gluster-devel mailing list Gluster-devel@xxxxxxxxxxx http://www.gluster.org/mailman/listinfo/gluster-devel
