Bitrot stub forget()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hey Raghu,

Bitrot stub inode forget implementation (br_stub_forget()) deletes the bad object
marker (under quarantine directory) if present. This looks incorrect as ->forget()
can be trigerred when inode table LRU size exceeeds configured limit - check bug
#1308961 which tracks this issue. I recall that protocol/server calls inode_forget()
on negative lookup (that might not invoke ->forget() though) and that's the reason
why br_stub_forget() has this code.

So, would it make sense to purge bad object marker just in lookup()? There might be
a need to do the same in unlink() in case the object was removed by the client.

Thoughts?

Thanks,

                Venky
_______________________________________________
Gluster-devel mailing list
Gluster-devel@xxxxxxxxxxx
http://www.gluster.org/mailman/listinfo/gluster-devel



[Index of Archives]     [Gluster Users]     [Ceph Users]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux