Suggestion: Might be in the implementation could be better to put comment in the new arbiter code. : why its implemented that way. ----- Original Message ----- From: "Pranith Kumar Karampuri" <pkarampu@xxxxxxxxxx> To: "Dan Lambright" <dlambrig@xxxxxxxxxx> Cc: "Ravishankar N" <ravishankar@xxxxxxxxxx>, "Gluster Devel" <gluster-devel@xxxxxxxxxxx>, "Joseph Fernandes" <josferna@xxxxxxxxxx>, "Nithya Balachandran" <nbalacha@xxxxxxxxxx>, "Mohammed Rafi K C" <rkavunga@xxxxxxxxxx> Sent: Saturday, January 23, 2016 10:25:15 AM Subject: Re: Reverse brick order in tier volume- Why? On 01/23/2016 10:02 AM, Dan Lambright wrote: > > ----- Original Message ----- >> From: "Pranith Kumar Karampuri" <pkarampu@xxxxxxxxxx> >> To: "Ravishankar N" <ravishankar@xxxxxxxxxx>, "Gluster Devel" <gluster-devel@xxxxxxxxxxx>, "Dan Lambright" >> <dlambrig@xxxxxxxxxx>, "Joseph Fernandes" <josferna@xxxxxxxxxx>, "Nithya Balachandran" <nbalacha@xxxxxxxxxx>, >> "Mohammed Rafi K C" <rkavunga@xxxxxxxxxx> >> Sent: Friday, January 22, 2016 10:48:15 PM >> Subject: Re: Reverse brick order in tier volume- Why? >> >> >> >> On 01/22/2016 03:48 PM, Ravishankar N wrote: >>> On 01/19/2016 06:44 PM, Ravishankar N wrote: >>>> 1) Is there is a compelling reason as to why the bricks of hot-tier >>>> are in the reverse order ? >>>> 2) If there isn't one, should we spend time to fix it so that the >>>> bricks appear in the order in which they were given at the time of >>>> volume creaction/ attach-tier *OR* just continue with the way things >>>> are currently because it is not that much of an issue? >>> Dan / Joseph - any pointers? > This order was an artifact of how the volume is created using legacy code and data structures in glusterd-volgen.c. Two volume graphs are built (the hot and the cold). The two graphs are built and combined in a single list. As far as I know, nobody has run into trouble with this. Refactoring the code would be fine to ease maintainability. Cool, the reason we ask is, that in arbiter volumes, 3rd brick is going to be the arbiter. If the bricks are in reverse order, it will lead to confusion. We will change it with our implementation of attach-tier for replica+arbiter bricks. Pranith > > >> +Nitya, Rafi as well. >>> -Ravi >>> >>> >>> _______________________________________________ >>> Gluster-devel mailing list >>> Gluster-devel@xxxxxxxxxxx >>> http://www.gluster.org/mailman/listinfo/gluster-devel >> _______________________________________________ Gluster-devel mailing list Gluster-devel@xxxxxxxxxxx http://www.gluster.org/mailman/listinfo/gluster-devel
