Richard, what's great about your patch (besides lockless counters) is: - JSON easier to parse (particularly in python). Compare to parsing "gluster volume profile" output, which is much more difficult. This will enable tools to display profiling data in a user-friendly way. Would be nice if you attached a sample output to the bz 1261700. - client side capture - io-stats translator is at the top of the translator stack so we would see latencies just like the application sees them. "gluster volume profile" provides server-side latencies but this can be deceptive and fails to report "user experience" latencies. I'm not that clear on the UI for it, would be nice if "gluster volume " command could be set up to automatically poll this data at a fixed rate like many other perf utilities (example: iostat), so that user could capture a Gluster profile over time with a single command; at present the support team has to give them a script to do it. This would make it trivial for a user to share what their application is doing from a Gluster perspective, as well as how Gluster is performing from the client's perspective. /usr/sbin/gluster utility can run on the client now since it is in gluster-cli RPM right? So in other words it would be great to replace this: gluster volume profile $volume_name start gluster volume profile $volume_name info > /tmp/past for min in `seq 1 $sample_count` ; do sleep $sample_interval gluster volume profile $volume_name info done > gvp.log gluster volume profile $volume_name stop With this: gluster volume profile $volume_name $sample_interval $sample_count > gvp.log And be able to run this command on the client to use your patch there. thx -ben ----- Original Message ----- > From: "Richard Wareing" <rwareing@xxxxxx> > To: gluster-devel@xxxxxxxxxxx > Sent: Wednesday, September 9, 2015 10:24:54 PM > Subject: Feature: FOP Statistics JSON Dumps > > Hey all, > > I just uploaded a clean patch for our FOP statistics dump feature @ > https://bugzilla.redhat.com/show_bug.cgi?id=1261700 . > > Patches cleanly to v3.6.x/v3.7.x release branches, also includes io-stats > support for intel arch atomic operations (ifdef'd for portability) such that > you can collect data 24x7 with a negligible latency hit in the IO path. > We've been using this for quite sometime and there appeared to have been > some interest at the dev summit to have this in mainline; so here it is. > > Take a look, and I hope you find it useful. > > Richard _______________________________________________ Gluster-devel mailing list Gluster-devel@xxxxxxxxxxx http://www.gluster.org/mailman/listinfo/gluster-devel
