Atin Mukherjee <amukherj@xxxxxxxxxx> wrote:
> it hangs on gverify.sh
While there, for the sake of portability it should not depend on bash.
While it is reasonable to expect bash to be installed for running the
test suite, IMO the non test stuff should try to lower dependencies, and
bash is easy to avoid.
Here I see 3 points
1) remove the function keyword
POSIX shell defines function like this:
foo() {
}
2) Avoid [[ ]] evaluations. They are the same as [ ] with locale used,
and it is not obvious locale is needed in that script. Remplacing
[[ ]] by [ ] should do it.
3) Avoid /dev/tcp usage
Here it is not obvious without introducing another dependency (on netcat
for instance). But since we probe the port before trying to run ssh, We
could just give up on the probe and run ssh with -oConnectTimeout so
that it does not hang forever.
--
Emmanuel Dreyfus
http://hcpnet.free.fr/pubz
manu@xxxxxxxxxx
_______________________________________________
Gluster-devel mailing list
Gluster-devel@xxxxxxxxxxx
http://www.gluster.org/mailman/listinfo/gluster-devel
