On 04/28/2015 01:24 PM, Emmanuel Dreyfus wrote: > On Tue, Apr 28, 2015 at 12:15:11PM +0530, Atin Mukherjee wrote: >> I see netbsd regression doesn't execute peer probe from any other tests >> apart from mgmt_v3-locks.t, if it had that would have also failed. So >> the conclusion is peer probe doesn't work in netbsd. > > It does not work anymore: that works in release-3.6, and it broke > quite recently in master. > >> http://review.gluster.org/#/c/10147/ is the cause for it. I will >> continue to investigate on this, however I am not able to understand >> what this line __asm__ __volatile__("ud2") indicating. Any experts :) ? > > This is the implementation for that in glusterd_peerinfo_new(): > new_peer->generation = uatomic_add_return (&conf->generation, 1); > > Are new_peer->generation and conf->generation sane? The expectation from the above statement is to execute new_peer->generation = ++conf->generation atomically > -- ~Atin _______________________________________________ Gluster-devel mailing list Gluster-devel@xxxxxxxxxxx http://www.gluster.org/mailman/listinfo/gluster-devel
