On Tue, Mar 31, 2015 at 12:14:29PM +0530, Vijay Bellur wrote: > On 03/28/2015 02:08 PM, Emmanuel Dreyfus wrote: > >Pranith Kumar Karampuri <pkarampu@xxxxxxxxxx> wrote: > > > >>Emmanuel, > >> What can we do to make it vote -2 when it fails? Things will > >>automatically fall in place if it gives -2. > > > >I will do this once I will have recovered. The changelog change broke > >regression for weeks, and now we have a fix for it I discover many other > >poblems have crop. > > > >While there, to anyone: > >- dd bs=1M is not portable. Use > > dd bs=1024k > >- echo 3 > /proc/sys/vm/drop_caches is not portable. use instead this > >command that fails but flushes inodes first. > > ( cd $M0 && umount $M0 ) > >- umount $N0 brings many problems, use instead > > EXPECT_WITHIN $UMOUNT_TIMEOUT "Y" umount_nfs $N0 > > > > > I wonder if we can add these as checks to flag errors in checkpatch.pl so > that we nip these problems off even before they appear for review? That would surely be good. I heard that Kaushal understands and can write Perl ;-) While on the topic of checkpatch.pl, having a check for empty commit messages and multi-line subjects would be nice too. Niels _______________________________________________ Gluster-devel mailing list Gluster-devel@xxxxxxxxxxx http://www.gluster.org/mailman/listinfo/gluster-devel
