On Thu, Dec 18, 2014 at 11:40 AM, Joe Julian <joe@xxxxxxxxxxxxxxxx> wrote:
> James, why not just compute the operating version? After 3.5.0 it's always
> XYYZZ based on the version.
>
> Something along the lines of
>
> $version_array = split("${gluster_version}", '[.]')
> if $version_array[0] < 3 {
> fail("Unsupported GlusterFS Version")
> }
> $operating_version = $version_array[2] ? {
> '4' => '2',
> '5' => $version_array[3] ? {
> '0' => '3',
> default => sprintf("%d%02d%02d", $version_array),
> },
> default => sprintf("%d%02d%02d", $version_array),
> }
>
>
> Perhaps a CLI command to fetch the GD_OP_VERSION_MAX might be beneficial as
> well.
This is a very good point actually... In fact, it begs the question:
If it can be computed from the version string, why doesn't GlusterFS
do this internally in libglusterfs/src/globals.h ?
I'm guessing perhaps there's a reason your computation isn't always correct...
Since that's not the case, I figured I'd just match whatever Gluster
is doing by actually storing the values in a yaml (hiera) "table". For
now I think it's fine, but if someone has better information, lmk!
>
>
> On 12/17/2014 11:30 PM, Kaushal M wrote:
>>
>> In that case, I should send a note as the op-version has been bumped
>> for the master branch.
>>
>> Please take note,
>> The operating-version for the master branch has been bumped to
>> '30700', which is aligned with the next release of GlusterFS, 3.7.
>>
>> ~kaushal
>>
>> On Thu, Dec 18, 2014 at 12:49 PM, Lalatendu Mohanty <lmohanty@xxxxxxxxxx>
>> wrote:
>>>
>>> On 12/17/2014 07:39 PM, Niels de Vos wrote:
>>>>
>>>> On Wed, Dec 17, 2014 at 08:40:18AM -0500, James wrote:
>>>>>
>>>>> Hello,
>>>>>
>>>>> If you plan on updating the operating-version value of GlusterFS,
>>>>> please
>>>>> either ping me (@purpleidea) or send a patch to puppet-gluster [1].
>>>>> Patches are 4 line yaml files, and you don't need any knowledge of
>>>>> puppet or yaml to do so.
>>>>>
>>>>> Example:
>>>>>
>>>>> +# gluster/data/versions/3.6.yaml
>>>>> +---
>>>>> +gluster::versions::operating_version: '30600' # v3.6.0
>>>>> +# vim: ts=8
>>>>>
>>>>> As seen at:
>>>>>
>>>>>
>>>>>
>>>>> https://github.com/purpleidea/puppet-gluster/commit/43c60d2ddd6f57d2117585dc149de6653bdabd4b#diff-7cb3f60a533975d869ffd4a772d66cfeR1
>>>>>
>>>>> Thanks for your cooperation! This will ensure puppet-gluster can always
>>>>> correctly work with new versions of GlusterFS.
>>>>
>>>> How about you post a patch that adds this request as a comment in the
>>>> glusterfs sources (libglusterfs/src/globals.h)?
>>>>
>>>> Or, maybe this should be noted on some wiki page, and have the comment
>>>> point to the wiki instead. Maybe other projects start to use the
>>>> op-version in future too, and they also need to get informed about a
>>>> change.
>>>>
>>> IMO we should make it a practice to send a mail to gluster-devel whenever
>>> a
>>> patch is sent to increase the operating-version. Similar to practice what
>>> Fedora follows for so version bump.
>>>
>>> -Lala
>>> _______________________________________________
>>> Gluster-devel mailing list
>>> Gluster-devel@xxxxxxxxxxx
>>> http://supercolony.gluster.org/mailman/listinfo/gluster-devel
>>
>> _______________________________________________
>> Gluster-devel mailing list
>> Gluster-devel@xxxxxxxxxxx
>> http://supercolony.gluster.org/mailman/listinfo/gluster-devel
>
>
> _______________________________________________
> Gluster-devel mailing list
> Gluster-devel@xxxxxxxxxxx
> http://supercolony.gluster.org/mailman/listinfo/gluster-devel
_______________________________________________
Gluster-devel mailing list
Gluster-devel@xxxxxxxxxxx
http://supercolony.gluster.org/mailman/listinfo/gluster-devel
