On 11/26/2014 08:19 AM, Mohammed Rafi K C wrote:
Hi All, We are planning to change the volume status command to show RDMA port for tcp,rdma volumes. We have four output designs in mind , those are, 1)Modify Port column as TCP,RDMA Ports Eg: Status of volume: xcube Gluster process TCP,RDMA Port Online Pid -------------------------------------------------------------------------------- Brick 192.168.44.108:/home/brick 49157,49158 Y 6030 NFS Server on localhost 2049 Y 6532 Self-heal Daemon on localhost N/A N 6234
In this method when RDMA is not present the heading will still read TCP, RDMA and entries would be of the <tcp-port> form.
Also if _only_ RDMA is present (if that is possible) this causes a presentation problem, at it would read ,<rdma-port> which is not nice. so my vote is a no.
2)Change entry in port as TCP-XXXXX,RDMA-XXXXX Eg: Status of volume: xcube Gluster process Port Online Pid --------------------------------------------------------------------------------- Brick 192.168.44.108:/home/brick TCP-49157,RDMA-49158 Y 6030 NFS Server on localhost TCP-2049 Y 6532 Self-heal Daemon on localhost N/A N 6234
This is better as it is extensible in the future as well (in case there are other such ports). I would personally like this as <portnum>(<protocol>) rather than the current form of <protocol>-<portnum>
3)Instead of column port add two other port as TCP Port and RDMA Port Eg: Status of volume: xcube Gluster process TCP Port RDMA Port Online Pid ------------------------------------------------------------------------------- Brick 192.168.44.108:/home/brick 49157 49158 Y 6030 NFS Server on localhost 2049 Y 6532 Self-heal Daemon on localhost N/A N 6234
This is cleaner, but later _if_ we need another column gets messy, but that is not a possibility in the near future, so a good candidate for consideration.
4) Make an extra row appending ".rdma" with brick name for rdma port Eg: Status of volume: xcube Gluster process Port Online Pid ------------------------------------------------------------------------ Brick 192.168.44.108:/home/brick 49157 Y 6030 Brick 192.168.44.108:/home/brick.rdma 49157 Y 6030 NFS Server on localhost 2049 Y 6532 Self-heal Daemon on localhost N/A N 6234
We really do not have multiple processes, so adding 2 each for a protocol port representation, misses the meaning of the header for this column, so a no from me.
Please give your comments regarding this designs, or if you have better idea in mind , feel free to share it. Best Regards Rafi KC _______________________________________________ Gluster-devel mailing list Gluster-devel@xxxxxxxxxxx http://supercolony.gluster.org/mailman/listinfo/gluster-devel
_______________________________________________ Gluster-devel mailing list Gluster-devel@xxxxxxxxxxx http://supercolony.gluster.org/mailman/listinfo/gluster-devel