Re: if/else coding style :-)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





[~/work/glusterfs]
sh$ git grep '} else {' | wc -l
     1331
[~/work/glusterfs]
sh$ git grep 'else {' | grep -v '}' | wc -l
      142

So going by just numbers, "} else {" is 10x more common than "}\n else
{". I also find that believable based on familiarity of seeing this
pattern in the code. Either way, good idea to stick to one and not allow
both in future code.

There are also 42 occurences of '} else {' in headers. And one occurence of '} else{' and two occurrences of '}else {'.

Versus one lonely occurence of '}\nelse {' in headers.

My main objection is that the change was made without any public discussion, after having agreed to something different.

Could we please revert the change to the check-in script?

Thanks.

--

Kaleb

_______________________________________________
Gluster-devel mailing list
Gluster-devel@xxxxxxxxxxx
http://supercolony.gluster.org/mailman/listinfo/gluster-devel




[Index of Archives]     [Gluster Users]     [Ceph Users]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux