Re: regarding message for '-1' on gerrit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 07/06/2014 11:05 PM, Vijay Bellur wrote:
On 07/06/2014 07:47 PM, Pranith Kumar Karampuri wrote:
hi Justin/Vijay,
      I always felt '-1' saying 'I prefer you didn't submit this' is a
bit harsh. Most of the times all it means is 'Need some more changes' Do
you think we can change this message?


The message can be changed. What would everyone like to see as appropriate messages accompanying values '-1' and '-2'?
For '-1' - 'Please address the comments and Resubmit.'
I am not sure about '-2'

Pranith

-Vijay


_______________________________________________
Gluster-devel mailing list
Gluster-devel@xxxxxxxxxxx
http://supercolony.gluster.org/mailman/listinfo/gluster-devel




[Index of Archives]     [Gluster Users]     [Ceph Users]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux