http://review.gluster.org/#/c/8181/ - posted a new change, wouldn't it be worth to add this in smoke tests? rather than at ./rfc.sh ? - we can provide a detailed summary - since we do not have 'commit/push' style patch submission. We can leverage our smoke tests, thoughts? On Wed, Jun 25, 2014 at 7:12 PM, James <purpleidea@xxxxxxxxx> wrote: > On Wed, Jun 25, 2014 at 9:35 PM, Jeff Darcy <jdarcy@xxxxxxxxxx> wrote: >>> While I agree with everything you said. Complaining about tabs/spaces >>> should be done by a script. Something like >>> http://review.gluster.com/#/c/5404 >>> Some one who knows perl should help us with rebasing it and getting it in >> >> Agreed. If there are standards that are going to be enforced even if >> they're counterproductive (and I think several aspects of our coding >> standard fit that description) then we should at least enforce them >> quickly via a checkin script instead of making people run regressions >> twice. > > > I too agree that using spaces instead of tabs is counterproductive. ;) > > It could be worse though: http://www.emacswiki.org/emacs/TabsSpacesBoth > _______________________________________________ > Gluster-devel mailing list > Gluster-devel@xxxxxxxxxxx > http://supercolony.gluster.org/mailman/listinfo/gluster-devel -- Religious confuse piety with mere ritual, the virtuous confuse regulation with outcomes _______________________________________________ Gluster-devel mailing list Gluster-devel@xxxxxxxxxxx http://supercolony.gluster.org/mailman/listinfo/gluster-devel