Re: Reviewing patches early

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 06/26/2014 06:19 AM, Justin Clift wrote:
On 26/06/2014, at 1:40 AM, Pranith Kumar Karampuri wrote:
<snip>
While I agree with everything you said. Complaining about tabs/spaces should be done by a script. Something like http://review.gluster.com/#/c/5404
+1

And we can use a git trigger to reject future patches that have tabs in
them.
We can probably do it at the time of './rfc.sh'. It probably is easier as well? Have the script in the repo. Run it against the patches that are to be submitted.

Pranith

For bonus points, we should put info on the wiki on how to configure our
editors to do spaces properly.  eg .vimrc settings, and that kind of thing

+ Justin

--
GlusterFS - http://www.gluster.org

An open source, distributed file system scaling to several
petabytes, and handling thousands of clients.

My personal twitter: twitter.com/realjustinclift


_______________________________________________
Gluster-devel mailing list
Gluster-devel@xxxxxxxxxxx
http://supercolony.gluster.org/mailman/listinfo/gluster-devel




[Index of Archives]     [Gluster Users]     [Ceph Users]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux