Hi David,
Thanks for reporting looks like it was a blatant mistake on our side, since we never used these functions these issues were not exposed. Sending a follow up fix.
Thanks again
On Fri, Oct 18, 2013 at 12:57 PM, David Binderman <dcb314@xxxxxxxxxxx> wrote:
Hello there,
I just ran the static analysis tool "cppcheck" over the source
code of glusterfs-3.4.1
It said many things, including
1.
> dict.c:916:2: warning: logical 'or' of collectively exhaustive tests is always true [-Wlogical-op]
Source code is
if ((SHRT_MAX> value) || (SHRT_MIN < value)) {
Maybe something like
if ((SHRT_MAX < value) || (SHRT_MIN> value)) {
was intended.
2.
> dict.c:948:2: warning: logical 'or' of collectively exhaustive tests is always true [-Wlogical-op]
Duplicate.
Regards
David Binderman
_______________________________________________
Gluster-devel mailing list
Gluster-devel@xxxxxxxxxx
https://lists.nongnu.org/mailman/listinfo/gluster-devel
Religious confuse piety with mere ritual, the virtuous confuse regulation with outcomes
