Ram Raja, Kaleb,
This patch is "almost" right. However I think we need an extra
AC_CHECK_HEADERS[Python.h]. This is because on systems where
python-devel RPM is missing, BUILD_PYTHON_INC successfully gets set even
though headers are not installed (that BUILD_PYTHON_INC variable is the
location of where the headers will be, if at all. It does not guarantee
the headers are actually installed).
Also please provide a way to disable glupy build. I was pretty much
stuck (i.e, when python installed, python-devel not installed). As with
all other autoconf tunables in our configure.ac, please use the
following strategy:
- If neither --enable-<feature> nor --disable-<feature> is specified,
auto detect availability of dependencies (Python.h, etc.) and decide.
- If --disable-glupy is specified, do not build even if dependencies
might be met.
- If --enable-glupy is specified, check for dependencies and fail the
configure script if unmet.
- Print the decision in the "configure summary" at the end in any case
(unless script was failed in step 3)
This is the standard pattern followed in pretty much all the
sub-sections of configure.ac and we need to stay uniform in this aspect.
Thanks!
Avati
On 05/19/2013 06:13 AM, Vijay Bellur (Code Review) wrote:
Vijay Bellur has submitted this change and it was merged.
Change subject: configure.ac: build glupy with installed python
......................................................................
configure.ac: build glupy with installed python
IOW with more than just python2.6. Python2.7 is certainly what's on
the vast majority of non-RHEL systems that are out there. Also our
rpm.t regression test will build on epel-5 under mock; RHEL5 has
Python2.4.
Change-Id: I09c95c1fb6b3498e910ad239c4f0af7f786c3700
BUG: 961856
Signed-off-by: Kaleb S. KEITHLEY<kkeithle@xxxxxxxxxx>
Reviewed-on: http://review.gluster.org/5007
Reviewed-by: Jeff Darcy<jdarcy@xxxxxxxxxx>
Tested-by: Gluster Build System<jenkins@xxxxxxxxxxxxxxxxx>
---
M configure.ac
M glusterfs.spec.in
M xlators/features/glupy/src/Makefile.am
M xlators/features/glupy/src/glupy.c
4 files changed, 24 insertions(+), 28 deletions(-)
Approvals:
Jeff Darcy: Looks good to me, approved
Gluster Build System: Verified
