yeah. mv'ed the file out of the source tree, did a new git branch, and mv ' ed the file over back in. its prolly not the way its supposed to go, but it works ;) - John Smith On Sun, May 19, 2013 at 11:51 PM, John Smith <lbalbalba@xxxxxxxxx> wrote: > Ok, trying to do that now... but the 1st submit failed (something > about the comment line being too long), and now rfc.sh gives me this: > > ./rfc.sh > [detached HEAD 254e730] tests: this fixes test bug-823081.t for bug-962226 > 1 file changed, 6 insertions(+), 4 deletions(-) > Commit: "this test is supposed to hit 'nfs-fops.c' a little better." > Enter Bug ID: > [detached HEAD 8cb27e7] this test is supposed to hit 'nfs-fops.c' a > little better. > 1 file changed, 62 insertions(+) > create mode 100755 tests/basic/nfs-fops.t > Successfully rebased and updated refs/heads/nfs-fops. > Counting objects: 15, done. > Delta compression using up to 2 threads. > Compressing objects: 100% (10/10), done. > Writing objects: 100% (10/10), 1.74 KiB, done. > Total 10 (delta 7), reused 0 (delta 0) > remote: Resolving deltas: 100% (7/7) > remote: Processing changes: refs: 2, done > To ssh://lbalbalba@xxxxxxxxxxxxxxx/glusterfs.git > ! [remote rejected] HEAD -> refs/for/master/rfc (no changes made) > error: failed to push some refs to > 'ssh://lbalbalba@xxxxxxxxxxxxxxx/glusterfs.git' > > > > I dont know enough about git to fix this. > :( > The file is './tests/basic/nfs-fops.t'. > > Help much appreciated > ;) > > > - John Smith. > > > > On Sun, May 19, 2013 at 8:21 PM, Vijay Bellur <vbellur@xxxxxxxxxx> wrote: >> On 05/19/2013 11:21 PM, John Smith wrote: >>> >>> Oh, looks like you cant do *any* io redirection *at*all* inside the >>> tests... bummer .... >>> >>> Ok, so now ive got this nifty new working test that hits some >>> previously (i think) uncovered code. Whats the way to get feedback on >>> it and/or get it included (if its good enough) i the git repository ? >>> Do I post it on the list ? (like now), chat on IRC ? just go ahead and >>> do a git commit; rfc.sh on the thing ? >> >> >> rfc.sh would be good for getting feedback. >> >> -Vijay >>
