On Tue, Sep 25, 2012 at 04:16:03PM +0800, Jules Wang wrote: > hi, Emmanuel: > If you are using glusterfs 3.3, this patch http://review.gluster.com/#patch,sidebyside,362,16,rpc/rpc-transport/socket/src/socket.c > and the following code in the patch will be helpful: Thanks, I will try this. While I am there, the whole SSL patch almost applies to release-3.3, there is the only exception of the last change: --- a/xlators/protocol/server/src/server-rpc-fops.c +++ b/xlators/protocol/server/src/server-rpc-fops.c @@ -3462,7 +3462,8 @@ server3_3_release (rpcsvc_request_t *req) conn = req->trans->xl_private; if (!conn) { - req->rpc_err = GARBAGE_ARGS; + /* Handshake is not complete yet. */ + req->rpc_err = SYSTEM_ERR; goto out; } gf_fd_put (conn->fdtable, args.fd); Does it makes sense to make the exact same change in xlators/protocol/server/src/server3_1-fops.c in order to get SSL on release-3.3? -- Emmanuel Dreyfus manu@xxxxxxxxxx
