That too seems to be fixed through the attached patch.
Unfortunately, both these patches have been under review
so are not available in the repo yet.
Do let us know of further problems.
Thanks
Shehjar
Tomasz Z. Napierala wrote:
Dnia 2009-05-18, pon o godzinie 16:54 +0200, Shehjar Tikoo pisze:
Tomasz Z. Napierala wrote:
Hi there,
Hi Tomasz,
A patch to fix this is ready now. Give us a few hours to push it
upstream.
Unfortunately I got another erroe: Making all in libglusterfsclient
Making all in src if /bin/sh ../../libtool --tag=CC --mode=compile
gcc -DHAVE_CONFIG_H -I. -I. -I../.. -D_FILE_OFFSET_BITS=64
-DGF_SOLARIS_HOST_OS -D__USE_FILE_OFFSET64 -D_GNU_SOURCE
-I../../libglusterfs/src -DDATADIR= \"/usr/local/var\"
-DCONFDIR=\"/usr/local/etc/glusterfs\" -I../../argp-standalone
-D_REENTRANT -fPIC -Wall -pthread -g -O2 -MT
libglusterfsclient_la-libglusterfsclient.lo -MD -MP -MF
".deps/libglusterfsclient_la-libglusterfsclient.Tpo" -c -o
libglusterfsclient_la-libglusterfsclient.lo `test -f
'libglusterfsclient.c' || echo './'`libglusterfsclient.c; \ then mv
-f ".deps/libglusterfsclient_la-libglusterfsclient.Tpo"
".deps/libglusterfsclient_la-libglusterfsclient.Plo"; else rm -f
".deps/libglusterfsclient_la-libglusterfsclient.Tpo"; exit 1; fi
libtool: compile: gcc -DHAVE_CONFIG_H -I. -I. -I../..
-D_FILE_OFFSET_BITS=64 -DGF_SOLARIS_HOST_OS -D__USE_FILE_OFFSET64
-D_GNU_SOURCE -I../../libglusterfs/src "-DDATADIR=\"/usr/local/var\""
"-DCONFDIR=\"/usr/local/etc/glusterfs\"" -I../../argp-standalone
-D_REENTRANT -fPIC -Wall -pthread -g -O2 -MT
libglusterfsclient_la-libglusterfsclient.lo -MD -MP -MF
.deps/libglusterfsclient_la-libglusterfsclient.Tpo -c
libglusterfsclient.c -fPIC -DPIC -o
.libs/libglusterfsclient_la-libglusterfsclient.o gcc: unrecognized
option `-pthread' In file included from libglusterfsclient.c:39:
libglusterfsclient.h:23:23: sys/cdefs.h: No such file or directory In
file included from /usr/include/sys/vnode.h:44, from
/usr/include/sys/vfs.h:40, from libglusterfsclient.h:31, from
libglusterfsclient.c:39: /usr/include/sys/rwstlock.h:45: error:
syntax error before "typedef" In file included from
/usr/include/sys/vnode.h:52, from /usr/include/sys/vfs.h:40, from
libglusterfsclient.h:31, from libglusterfsclient.c:39:
/usr/include/sys/list.h:50: error: conflicting types for
'list_move_tail' ../../libglusterfs/src/list.h:89: error: previous
definition of 'list_move_tail' was here In file included from
libglusterfsclient.c:39: libglusterfsclient.h:883: warning: "struct
statfs" declared inside parameter list libglusterfsclient.h:883:
warning: its scope is only this definition or declaration, which is
probably not what you want libglusterfsclient.h:897: warning: "struct
statfs" declared inside parameter list In file included from
/usr/include/iso/signal_iso.h:49, from /usr/include/signal.h:43, from
libglusterfsclient-internals.h:29, from libglusterfsclient.c:40:
/usr/include/sys/iso/signal_iso.h:101: error: syntax error before
"extern" libglusterfsclient.c: In function `zr_build_process_uuid':
libglusterfsclient.c:111: warning: int format, pid_t arg (arg 5)
libglusterfsclient.c: At top level: libglusterfsclient.c:5154:
warning: "struct statfs" declared inside parameter list
libglusterfsclient.c:5155: error: conflicting types for
'glusterfs_glh_statfs' libglusterfsclient.h:883: error: previous
declaration of 'glusterfs_glh_statfs' was here
libglusterfsclient.c:5155: error: conflicting types for
'glusterfs_glh_statfs' libglusterfsclient.h:883: error: previous
declaration of 'glusterfs_glh_statfs' was here libglusterfsclient.c:
In function `glusterfs_glh_statfs': libglusterfsclient.c:5189: error:
dereferencing pointer to incomplete type libglusterfsclient.c:5190:
error: dereferencing pointer to incomplete type
libglusterfsclient.c:5191: error: dereferencing pointer to incomplete
type libglusterfsclient.c:5192: error: dereferencing pointer to
incomplete type libglusterfsclient.c:5193: error: dereferencing
pointer to incomplete type libglusterfsclient.c:5194: error:
dereferencing pointer to incomplete type libglusterfsclient.c:5195:
error: dereferencing pointer to incomplete type
libglusterfsclient.c:5203: error: dereferencing pointer to incomplete
type libglusterfsclient.c:5204: error: dereferencing pointer to
incomplete type libglusterfsclient.c: At top level:
libglusterfsclient.c:5215: warning: "struct statfs" declared inside
parameter list libglusterfsclient.c:5216: error: conflicting types
for 'glusterfs_statfs' libglusterfsclient.h:897: error: previous
declaration of 'glusterfs_statfs' was here libglusterfsclient.c:5216:
error: conflicting types for 'glusterfs_statfs'
libglusterfsclient.h:897: error: previous declaration of
'glusterfs_statfs' was here
Regards,
Date: Mon, 18 May 2009 17:25:24 +0530
From: "Anand V. Avati" <avati@xxxxxxxxxxx>
To: reviews@xxxxxxxxxxx
Subject: [PATCH] workaround for not including sys/cdefs.h -- including sys/cdefs.h breaks build on solaris and other platforms
---
libglusterfsclient/src/libglusterfsclient.h | 17 ++++++++++++++++-
1 files changed, 16 insertions(+), 1 deletions(-)
diff --git a/libglusterfsclient/src/libglusterfsclient.h b/libglusterfsclient/src/libglusterfsclient.h
index 1c2441b..5376985 100755
--- a/libglusterfsclient/src/libglusterfsclient.h
+++ b/libglusterfsclient/src/libglusterfsclient.h
@@ -20,7 +20,22 @@
#ifndef _LIBGLUSTERFSCLIENT_H
#define _LIBGLUSTERFSCLIENT_H
-#include <sys/cdefs.h>
+#ifndef __BEGIN_DECLS
+#ifdef __cplusplus
+#define __BEGIN_DECLS extern "C" {
+#else
+#define __BEGIN_DECLS
+#endif
+#endif
+
+#ifndef __END_DECLS
+#ifdef __cplusplus
+#define __END_DECLS }
+#else
+#define __END_DECLS
+#endif
+#endif
+
__BEGIN_DECLS
--
1.6.0.3
--
Anand V. Avati
gpg --keyserver pgp.mit.edu --recv-keys 0xCBFFAC67
http://80x25.org/~avati
