Hi, On Tue, 31 Mar 2009, P Baker wrote: > > > *Moving objects from submodule .git directories into the base .git/ > > > directory would protect the submodules and is a good idea. > > > > No, I did not say that. > > > > Even worse, I think that moving the .git/ directory into the > > superproject's .git/ would be at least quite a bit awkward in the > > nested case. > > > > Tthe initial prompt for the proposal was: "Rewrite git-submodule, > placing the repository for each referenced submodules in the > superproject's $GIT_DIR/modules...This resolves issues related to > switching between versions of the superproject..." The prompt, and > past experience with git, helped me to form my proposal which it seems > would fix numerous problems with git submodule, with the implied cost > of some awkwardness/complexity. Am I misunderstanding the prompt? Or > do you think this could be accomplished more elegantly? Well, I think the focus here is wrong. The focus should be on the working directory as hinted here: > > I said that moving submodules' working directory need to protected > > when renaming/deleting submodules. > > I'm sorry, I still don't understand. Where would this occur? What is > being protected? What is the submodules' working directory? I'm still > learning the intricacies of git, so I'd appreciate any pointers you can > give. If your superproject deletes a submodule, what should happen with the working directory? And what should happen if the submodule is _moved_? (Which is not as easily detected as with renamed files or directories.) > > Further, often it would come in rather handy to be able to say > > something like "git diff $REVISION_AS_COMMITTED_IN_THE_SUPERPROJECT" > > from within the submodule... > > > > That sounds complex, and would break expectations. This would only > work if git in the submodule working directory knows its a submodule. ... or can detect easily that it is a submodule. > Is there a way to reference it's super project? No. > > Oh, and it would not hurt performance on Windows at all if > > git-submodule would be finally made a builtin. > > You mean rewriting git-submodule.sh in C? What other impacts might that > have? Junio would hate it, I am sure. Ciao, Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
