Jeff King <peff@xxxxxxxx> writes: > On Tue, Mar 31, 2009 at 10:32:14AM -0700, Junio C Hamano wrote: > >> My point was if I belong only to my personal group and git.git work tree >> is owned by junio.junio to begin with, you would never be able to notice >> any breakage with such a test. > > Ah, I see. Yes, you would need to belong to at least two groups to make > such a test feasible. > > Such a requirement is generally outside the scope of running the > test suite; do you want to just ditch the g+s test, then, or do you want > me to work up something conditional based on the Makefile flag? For now, I'd suggest teaching the test not to care about g+s bit. After all, they are about giving correct mode bits to files and directories. Correct mode bits for group do not mean anything if you make them owned by a wrong group, but that is not something we have tested so far, and can be a separate test anyway. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
