[I'm cc'ing the git-list; please send bug reports there] On Tue, Mar 31, 2009 at 01:47:47AM +0200, Pierre Poissinger wrote: > Looks like the patch posted here > http://osdir.com/ml/git/2009-01/msg01128.html > (around d8e96fd86d415554a9c2e09ffb929a9e22fdad25 I think - too late to > look for it - love google that gave me this guy as first hit...) > > breaks git on AIX 5.2 with gcc 2.9 :-( Wow, I didn't know people were still using the 2.9 branch of gcc. > Nothing new to pack. > trace: built-in: git 'prune-packed' > The end... > fatal: unable to run 'git-repack' > error: waitpid 155256: code 128 (Error 0) > error: failed to run repack Hmm. Can you confirm the status being passed back by run_command? The following patch should do it: diff --git a/git.c b/git.c index c2b181e..a99c31b 100644 --- a/git.c +++ b/git.c @@ -413,6 +413,7 @@ static void execv_dashed_external(const char **argv) * OK to return. Otherwise, we just pass along the status code. */ status = run_command_v_opt(argv, 0); + fprintf(stderr, "run_command produced status %d\n", status); if (status != -ERR_RUN_COMMAND_EXEC) { if (IS_RUN_COMMAND_ERR(status)) die("unable to run '%s'", argv[0]); > The bottom line: Looks like my box really don't like the run-command > error define as: > #define IS_RUN_COMMAND_ERR(x) ((x) <= -ERR_RUN_COMMAND_FORK) > > it will trigger even with x==0 :-) That seems very wrong. I wonder if it is a problem with the signedness of enums in that version of gcc. Can you run the following program and report on its output? -- >8 -- #include <stdio.h> enum { FOO = 10000 }; int main() { printf("-FOO: %d\n", -FOO); printf("0 <= -FOO: %d\n", 0 <= -FOO); printf("-10000 <= -FOO: %d\n", -10000 <= -FOO); return 0; } -- 8< -- > So, following patch simply change this define to > #define IS_RUN_COMMAND_ERR(x) ((x) > ERR_RUN_COMMAND_FORK) That's not right; x is going to be a large negative value. You could try: #define IS_RUN_COMMAND_ERR(x) ((-x) > ERR_RUN_COMMAND_FORK) The other option is to rework run_command to just return positive values (which should be fine as long as they remain out of the range of normal exit codes). -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
