On Saturday 28 March 2009, Junio C Hamano wrote: > Johan Herland <johan@xxxxxxxxxxx> writes: > > When writing out a loose object or a pack (index), move_temp_to_file() > > is called to finalize the resulting file. These files (loose files and > > packs) should all have permission mode 0444 (modulo > > adjust_shared_perm()). Therefore, instead of doing chmod(foo, 0444) > > explicitly from each callsite (or even forgetting to chmod() at all), > > do the chmod() call from within move_temp_to_file(). > > I think you would need this on top. Agreed. Thanks, ..Johan -- Johan Herland, <johan@xxxxxxxxxxx> www.herland.net -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
