Hi,
On Wed, 25 Mar 2009, Elijah Newren wrote:
> On Wed, Mar 25, 2009 at 4:13 PM, Johannes Schindelin
> <Johannes.Schindelin@xxxxxx> wrote:
> >> - if (commit->parents) {
> >> + if (commit->parents &&
> >> + get_object_mark(&commit->parents->item->object) != 0) {
> >> parse_commit(commit->parents->item);
> >> diff_tree_sha1(commit->parents->item->tree->object.sha1,
> >> commit->tree->object.sha1, "", &rev->diffopt);
> >
> > I do not understand that change.
> >
> > A good explanation in the commit message might help this stupid
> > developer.
>
> I resent the patch in another email (sorry for the duplication, but I
> don't trust gmail to preserve patches, and responding inline to comments
> via git-send-email isn't so great either). Let me know if the
> explanation is missing anything, is too detailed, or is using incorrect
> terminology. In two cases I was sufficiently unsure about my wording
> that I provided extra wording to try to make it clear what I was talking
> about.
I am pretty tired, but I still have the impression that I understood it,
so yes, I like it.
You might want to skip the != 0, though, as we avoid that in the rest of
Git's source code, too.
Thanks,
Dscho
