Re: [PATCH v2 2/2] pack-objects: don't loosen objects available in alternate or kept packs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Junio,

I notice this patch is in next now (I noticed earlier than today,
but haven't said anything).

I just want to point one minor thing.  After figuring out why last_found
was initialized to (void *)1 rather then NULL, you seem to have committed
a version that was slightly different from what I submitted.  The logic
is the same, but now the following line is different from the line in
sha1_file.c where I copied it from:

builtin-pack-objects.c (line 1952):

   p = (last_found != (void *)1) ? last_found : packed_git;

sha1_file.c (line 1931): 

   p = (last_found == (void *)1) ? packed_git : last_found;


People should be able to easily recognize the two procedures as "the same".
This small difference may give them pause.  If it is possible to amend
this commit before applying to master, perhaps you would like to do so.
Otherwise, no big deal.

-brandon
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux