Re: [PATCH 1/8] Documentation: move callouts.xsl to manpage-{base,normal}.xsl

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2009 Mar 24, at 03:51, Jeff King wrote:
On Tue, Mar 24, 2009 at 03:04:19AM -0500, Chris Johnsen wrote:

 Documentation/Makefile           |    2 +-
Documentation/callouts.xsl | 30 ------------------------------ Documentation/manpage-base.xsl | 30 ++++++++++++++++++++++++++ ++++ Documentation/manpage-normal.xsl | 30 ++++++++++++++++++++++++++ ++++
 4 files changed, 61 insertions(+), 31 deletions(-)
 delete mode 100644 Documentation/callouts.xsl
 create mode 100644 Documentation/manpage-base.xsl
 create mode 100644 Documentation/manpage-normal.xsl

This is definitely a good change, though it would also be fine to
actually munge the contents in the same patch rather than duplicate them
(i.e., actually _split_ callouts.xsl instead of copying it to two
places).

I think it would have been much easier to read, though, by turning on
rename detection in format-patch (i.e., "-M"). That yields:


Thank you for looking at these. I will incorporate your feedback and resend in a couple of days.

I used -C -M in some early diffs to make sure it would "compress" like that, but I failed to do so for the final send-email.

--
Chris
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux