On Sun, Mar 22, 2009 at 02:58:35PM -0700, Junio C Hamano wrote: > > Junio, do you want to put anything in the release notes warning people > > who build from source that this is a potential issue? Do you want > > something in the Makefile detecting that the shell is broken? > > A sentence or two in INSTALL will not hurt. > > I would not worry too much about the test scripts, but I would worry more > about getting phantom bug reports for our shell script Porcelains that get > hit by this. Earlier I mentioned bisect is the only heavy user, but the > issue is more severe with filter-branch that is designed to eval end user > scripts (calls to 'eval "$filter_frotz"' check the exit status and die on > failure---with trailing blank lines the failure the filter reports will > not get caught). Agreed. The good news is that the /bin/sh people are treating it like a bug: http://lists.freebsd.org/pipermail/freebsd-standards/2009-March/001721.html so it will hopefully be fixed soon. It might still be worth warning users of older releases in INSTALL, though. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
