On Sun, 22 Mar 2009, Brandon Casey wrote:
> >> +static int has_sha1_pack_kept_or_nonlocal(const unsigned char *sha1)
> >> +{
> >> + static struct packed_git *last_found = (void *)1;
> >> + struct packed_git *p;
> >> +
> >> + p = (last_found == (void *)1) ? packed_git : last_found;
> >
> > Why (void *)1, not like:
> >
> > static struct packed_git *last_found;
> > struct packed_git *p = last_found ? last_found : packed_git;
> >
> > Am I missing something?
>
> Heh, I am missing something too. Maybe I should have _thought_ more
> about this code that I copied from sha1_file.c: find_pack_entry() and
> I would have asked the same question about _that_ code.
>
> Maybe Nico has some idea?
Well... I know this is my code, and I must have had a reason to keep
the NULL pointer distinct from the initial value. But at the moment I
just can't remember about it, and the code doesn't show a need for it
either.
Nicolas
