On Thu, Mar 19, 2009 at 7:02 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote: >> Do we really want an API for that? Calling qsort() directly should be >> obvious enough, no? > > I think so. If it were done like this (notice the lack of double > indirection in the cmp_fn signature): > > typedef int string_list_item_cmp_fn(const struct string_list_item *, const struct string_list_item *); > > void sort_string_list_with_fn(struct string_list *list, string_list_item_cmp_fn *); > > it would have made more sense, though. Oh, wow, sorry, I didn't even realize Jeff had just added that function. Somehow I missed that part of his patch. j. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
