El 18/3/2009, a las 5:35, David Aguilar escribió:
Junio C Hamano <gitster@xxxxxxxxx> wrote:
Markus Heidelberg <markus.heidelberg@xxxxxx> writes:
Jay Soffian <jaysoffian@xxxxxxxxx> wrote:
Aside, (for Junio I guess...), what's the reason this command is in
contrib, and by what criteria might it graduate to being installed
with the rest of the git commands?
j.
I'd like to see it as a general git tool, too.
Maybe it can even share some common functionality with git-
mergetool.
The code was copied and pasted very heavily, and I think (IIRC) the
author
was a bit too ashamed to have it outside contrib/ before it is
properly
refactored or something like that. Which I happen to agree with,
by the
way.
I'll work on some patches to get the ball rolling on this.
Here's what I see as the steps I would take:
1. move difftool into the root, update Makefile, etc.
2. factor out the similarities between merge/difftool and
put them in maybe git-tool-lib.sh?
Given that git-difftool shares basically all the same options as "git
diff", I think a good long-term plan would be looking at adding the "--
tool" option to "git diff" itself so that users wouldn't have to learn
a new subcommand, just a new option.
(Whether this is done by rolling the functionality of "git-difftool"
into "git diff" itself, or delegating to a separate "git-difftool"
command doesn't matter so much, now that most commands are neatly
tucked away in $(git --exec-path) now.)
Cheers,
Wincent
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
