Hi,
On Tue, 17 Mar 2009, Carlos Rica wrote:
> By using strbuf to save the signing-key id, it also imposes no limit
> to the length of the string obtained from the config or command-line.
> This string is then passed to gpg to sign the tag, when appropriate.
>
> Signed-off-by: Carlos Rica <jasampler@xxxxxxxxx>
> ---
>
>
> QUESTION: Is it safe to remove this limit?
I think so. GPG should return an error if it thinks it is too large.
> @@ -164,11 +162,10 @@ static int do_sign(struct strbuf *buffer)
> int len;
> int i, j;
>
> - if (!*signingkey) {
> - if (strlcpy(signingkey, git_committer_info(IDENT_ERROR_ON_NO_NAME),
> - sizeof(signingkey)) > sizeof(signingkey) - 1)
> - return error("committer info too long.");
> - bracket = strchr(signingkey, '>');
> + if (!signingkey->buf[0]) {
It is probably better to ask for !signingkey->len (think of trying to
understand the code in 6 months from now).
Other than that, very nice!
Ciao,
Dscho
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
