Re: [PATCH] Tests: use test_cmp instead of diff where possible

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Mar 15, 2009 at 02:33:56PM +0100, Miklos Vajna wrote:

> I intentionally did not touch t5000 - using test_cmp -r works for me,
> since the default is diff -u, but that would break the setup of users
> where GIT_TEST_CMP is set to cmp.

Definitely "test_cmp -r" is a bad idea since we don't know what
underlies it. But I wonder how portable "diff -r" is. Wasn't it a point
of contention in the recent cvsimport tests that were added (and Michael
ended up writing a mini recursive differ using some shell commands)?

OTOH, I haven't seen any complaints about it, so perhaps it is fine to
leave it.

-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux