On Mon, Mar 16, 2009 at 05:01:33PM +0100, Michael J Gruber wrote: > Now, a simple test shows that git diff obviously does this when diffing > HEAD to worktree: > > diff between HEAD and clean(worktree) > > Which is the right thing. It just seems so that textconv is not even > called "in the wrong place of the chain", but messes the diff up in this > way: > > diff between textconv(HEAD) and textconv(worktree) > > (I expected clean(textconv(worktree)) first, which would be wrong, too). > I.e., the clean filter is ignored completely in the presence of textconv. Yeah, I think this should probably be textconv(clean(worktree)) to match the regular HEAD/worktree diff (if it isn't already). Can you put together a test that shows the breakage? -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
