On 2009-03-16 16:36:43 +0000, Catalin Marinas wrote:
> 2009/3/13 Karl Hasselström <kha@xxxxxxxxxxx>:
>
> > On 2009-03-12 12:09:18 +0000, Catalin Marinas wrote:
> >
> > > options = [
> > > opt('-s', '--series', action = 'store_true',
> > > - short = 'Rearrange according to a series file')]
> > > + short = 'Rearrange according to a series file')
> > > + ] + argparse.keep_option()
> >
> > This flag should take the filename as a parameter, both because
> > it's the right thing to do and because it'll make the tab
> > completion work right (as is, it'll complete on patch names after
> > the -s flag).
> >
> > Something like
> >
> > opt('-s', '--series', type = 'string')
> >
> > ought to do it.
>
> This command was accepting series via the stdin as well (maybe for
> easier use in other scripts or from stgit.el).
Ah. Hmm, I'd prefer if it used "-" for that, for consistency. And
because I don't know how to make flags with optional parameters. :-/
> Anyway, it doesn't seem to make any difference with the bash
> completion. It still tries to complete patches but when this fails
> bash lists files if the prefix matches some.
Hmm, that's not right. But I can have a look at it if you like.
--
Karl Hasselström, kha@xxxxxxxxxxx
www.treskal.com/kalle
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
