On Sat, Mar 14, 2009 at 9:54 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote:
> Carlos Rica <jasampler@xxxxxxxxx> writes:
>
>> Signed-off-by: Carlos Rica <jasampler@xxxxxxxxx>
>> ---
>>
>> Here I declare a struct to wrap the new local array along with its size.
>> QUESTION: An alternative to this is strbuf, would it be preferable?
>
> The command already uses strbuf for other purposes, so why not?
strbuf is designed as an unlimited length buffer, and now the user
signing-key id (obtained from the config or as a command's argument)
is limited to the current static array size.
It is right to remove this limit? I haven't found something like
strlcpy for strbuf and I'm not sure if it would be a nice adition:
size_t strbuf_lcpy(struct strbuf *dest,
const char *src, size_t max);
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
