Re: [PATCH 1/2] Add a test for checking whether gitattributes is honored by checkout.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



ext Matthieu Moy wrote:
> Kristian Amlie <kristian.amlie@xxxxxxxxx> writes:
> 
>> +test_expect_success 'setup' '
> 
> If you have two separate patches for test and bugfix, you probably
> want the first to introduce test_expect_failure, and the second to
> change it to test_expect_success. This way: 1) the test-suite passes
> for all commits (and git-bisect will be your friend again), and 2) the
> second patch is self-explanatory about the bug it fixes.

Good point. I'll fix that in my next batch.

--
Kristian
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux