Re: [PATCH 7/7] bisect: use "rev-list --bisect-skip" and remove "filter_skipped" function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



These (except for the first one which I do not think belongs to the
series) look more or less straightforward changes.

One worrysome thing that the series introduces is that you used to hold
all the skipped ones in a shell variable $skip and fed it internally to
the filter_skipped shell function, but now you give them from the command
line.  When you have tons of skipped commits, this can easily bust the
command line length limit on some system, while the shell may still be Ok
with such a large string variable.

Because the operations in rev-list related to bisect are very closely tied
to the implementation of the bisect Porcelain anyway, I am wondering if it
makes more sense to just feed the name of the toplevel refname hierarchy,
i.e. "refs/bisect", as a rev-list parameter and let rev-list enumerate
what is skipped, which commits are good and which ones are bad.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux