On Wed, Mar 04, 2009 at 11:19:32PM +0900, Yasushi SHOJI wrote: > git plumbings has been working with binary diff for a while. this one > liner enable guilt to use those capabilities. > > Signed-off-by: Yasushi SHOJI <yashi@xxxxxxxxxxxxxxxxx> > --- > Hi Jeff, > > I just found out that guilt does not yet support binary patch > capability git has for a while. > > so, before I leave my office, I just tried guilt with this one liner. > the result was: > > - my local test with biniary files work (pop/push was check with md5), and > - all regression test completed without any error > > I felt that I just send it out. :-) That's how it works :) > # Note: I've googled "guilt bianry" before sending this but could not > # find any. I'm not following nether git nor guilt development for a > # while. so, let me know if I'm off track. Sorry for taking so long...the patch looks fine. I applied it & pushed it out. I think it would be a good idea to have a regression test that specifically checks binary file handling. I'm not going to get to write it for a couple of days at least, so feel free to give it a shot :) Thanks! Josef 'Jeff' Sipek. -- In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. - Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
