Please, don't even try to apply this patch, since long lines are wrapped.
I will send it fixed, sorry by the inconvenience.
On Tue, Mar 10, 2009 at 2:34 PM, Johannes Schindelin
<Johannes.Schindelin@xxxxxx> wrote:
> Hi,
>
> On Tue, 10 Mar 2009, Carlos Rica wrote:
>
>>
>> Signed-off-by: Carlos Rica <jasampler@xxxxxxxx>
>
> Good to see you again!
Thanks!
>
> BTW do you want to be recorded with a different email address in the
> author line than in the S-O-B?
Thank you for notify it, Johannes! That's was another mistake here,
I wanted to use the gmail account for this, I will change it when I
send this fixed.
>> -static int do_sign(struct strbuf *buffer)
>> +struct char_array {
>> + char *buf;
>> + size_t size;
>> +};
>
> That looks very much like you want a struct strbuf, no?
I was asking exactly that, in the hidden lines of the patch,
so if everybody prefers the strbuf solution I will use it, and then,
we should choose if there must be a limit for the signing key id max length
(now 1000) since by using dynamic memory it would not be required.
> Ciao,
> Dscho
>
>
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
