On Mon, Mar 09, 2009 at 07:49:47PM -0400, Daniel Barkalow wrote:
> On Mon, 9 Mar 2009, Finn Arne Gangstad wrote:
>
> > diff --git a/transport.h b/transport.h
> > index 6bbc1a8..b897d0c 100644
> > --- a/transport.h
> > +++ b/transport.h
> > @@ -34,6 +34,15 @@ struct transport {
> > #define TRANSPORT_PUSH_DRY_RUN 4
> > #define TRANSPORT_PUSH_MIRROR 8
> > #define TRANSPORT_PUSH_VERBOSE 16
> > +#define TRANSPORT_PUSH_MATCHING 32
> > +#define TRANSPORT_PUSH_CURRENT 64
> > +/**
> > + * All push flags that imply a certain set of refspecs to be pushed must
> > + * be combined into TRANSPORT_PUSH_MODE_MASK
> > + **/
> > +#define TRANSPORT_PUSH_MODE_MASK \
> > + (TRANSPORT_PUSH_ALL | TRANSPORT_PUSH_MIRROR | TRANSPORT_PUSH_MATCHING | \
> > + TRANSPORT_PUSH_CURRENT)
>
> It's kind of odd that you define these flags as TRANSPORT_PUSH_*, but
> implement them before entering transport_push(). I'm not sure which is
> right, but the combination is odd. I think just taking care of it in
> builtin-push with flags or options defined there is probably the best
> thing, currently.
True, this was not very beautiful. I will make something better.
- Finn Arne
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
