Re: [PATCH 1/2] Use a common function to get the pretty name of refs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Mon, 9 Mar 2009, Daniel Barkalow wrote:

> On Mon, 9 Mar 2009, Johannes Schindelin wrote:
> 
> > On Sun, 8 Mar 2009, Daniel Barkalow wrote:
> > 
> > > The result should be consistent between fetch and push, so we ought 
> > > to use the same code in both cases, even though it's short.
> > 
> > You might want to mention that we cannot use skip_prefix() here, as 
> > that function does not give us any clue if something was skipped at 
> > all, and we must _not_ skip multiple prefixes.
> 
> I didn't even know about the skip_prefix() function; I just moved code 
> around.

But I know the function.  And I had to look at the code to end the 
head-scratching.  Therefore I'd like the paragraph I wrote to be part of 
the commit message, to save other people from going bald.

Ciao,
Dscho

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux