On Mar 8, 2009, at 9:11 PM, Junio C Hamano wrote:
Sam Hocevar <sam@xxxxxxx> writes:
rm_so and rm_eo are ints on Linux but off_t's on Darwin, hence
probably int64_t's here. You should cast the arguments.
That is a very good point. In fact, "git grep -n -e 'printf.*%\.\*s'"
reveals that many existing call sites to this form casts the precision
argument explicitly to "int".
Brian, would this patch help?
Yes, except that the code also depends on printf("%.*s", 0, str)
working properly. I just sent a patch which checks for zero width and
performs the casts.
~~ Brian
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
