Match coloring is a major missing feature of git grep. It makes reading the output much easier and brings grep onto the same visual level as the other colorized git commands. Two earlier attempts to implement this feature didn't go in. They didn't support support pattern expressions (--and, --or etc.) or external greps, unlike this series. [PATCH 1/5] grep: micro-optimize hit collection for AND nodes [PATCH 2/5] grep: remove grep_opt argument from match_expr_eval() These are cleanup patches and unrelated to coloring. They touch the same code, though, so it's a good idea to take this opportunity to beautify the code a bit before adding new features. [PATCH 3/5] grep: add pmatch and eflags arguments to match_one_pattern() The two arguments added by this patch are used by the next one. [PATCH 4/5] grep: color patterns in output Add color support to internal git grep. [PATCH 5/5] grep: add support for coloring with external greps Extends color support to external greps. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html