On Thu, Mar 05, 2009 at 09:18:28AM +0200, Petri Hodju wrote:
> +static void format_source(struct strbuf *sb, const struct commit *commit)
> +{
> + if (commit->util)
> + strbuf_addstr(sb, (char *) commit->util);
> +}
> +
Hmm. This is the second patch in the last few weeks to use commit->util
to carry information for --pretty=format: (I am cc'ing Deskin Miller,
who wrote the first).
They cannot both work, obviously. So we need to do one of:
- refactor the information out of commit->util to somewhere else
- allow multiple commit->util users somehow (which I think is a
potential performance problem -- the simplistic design is meant to
avoid things like allocation overhead)
- gracefully block concurrent use of conflicting features
-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
