Jay Soffian <jaysoffian@xxxxxxxxx> writes:
> On Tue, Mar 3, 2009 at 6:54 AM, Bert Wesarg <bert.wesarg@xxxxxxxxxxxxxx> wrote:
>> On Tue, Mar 3, 2009 at 05:52, Jay Soffian <jaysoffian@xxxxxxxxx> wrote:
>>> diff --git a/git-send-email.perl b/git-send-email.perl
>>> index adf7ecb..57127aa 100755
>>> --- a/git-send-email.perl
>>> +++ b/git-send-email.perl
>>> @@ -837,6 +837,37 @@ X-Mailer: git-send-email $gitversion
>>> unshift (@sendmail_parameters,
>>> '-f', $raw_from) if(defined $envelope_sender);
>>>
>>> + if ($needs_confirm && !$dry_run) {
>> So, the output is now differnt with and without --dry-run?
>
> There doesn't seem to be any point in having the user confirm before
> sending the message if the message is not actually going to be sent.
> Am I missing something?
I do not think you are missing anything.
IIRC, the --dry-run mode shows more clearly to whom you would be CC'ing
the messages; in other words, the behaviour would be different, but it
gives an uninteractive way to confirm, and not pausing for confirmation is
a good thing.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
