Hi, On Mon, 2 Mar 2009, Junio C Hamano wrote: > Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes: > > > Or even > > > > current=$ONTO > > fd=3 > > while read command sha1 rest > > do > > case "$fd,$command,$current" in > > 3,pick,"$sha1"*|t,p,"$sha1"*) > > current=$sha1 > > ;; > > *) > > fd=1 > > ;; > > esac > > echo "$command $sha1 $rest" >&$fd > > done < "$TODO" > "$TODO.new" 3>> "$DONE" && > > mv "$TODO.new" "$TODO" > > > > Hmm? > > Certainly. > > Even though "3 means we haven't found a non-pick yet" feels slightly > hacky, the logic is contained in this small loop and I do not see it as a > problem. I'll add a one line comment. > As long as you are sure $ONTO and all sha1 can be compared without > running them through rev-parse, avoiding rev-parse per iteration is a > very attractive optimization. Yes, that is the beauty of abbreviated commit names: they are guaranteed to be unique, unless other objects were added since, which is not the case at this point. Ciao, Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
